From f5f50b9f31aa4eb86f53a085b01f13955434c80a Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Fri, 22 Feb 2013 10:23:43 +0000 Subject: [PATCH] viced: Allow GetCapabilities to return an error At the moment, the GetCapabilities RPC handler ignors errors from CallPreamble or CallPostamble. Instead of silently swallowing these, and potentially reutnring a bogus capabilities structure, make it possible for the RPC to return failure to the caller. Caught by clang-analyzer Reviewed-on: http://gerrit.openafs.org/9241 Tested-by: BuildBot Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman (cherry picked from commit ea0441520138d2129b5c6b2bd16c7640a8680146) Change-Id: Ic3828198e43403506f991455f09924387b483879 Reviewed-on: http://gerrit.openafs.org/9534 Tested-by: BuildBot Reviewed-by: Stephan Wiesand --- src/viced/afsfileprocs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/viced/afsfileprocs.c b/src/viced/afsfileprocs.c index 3b236634d..9f5517ad7 100644 --- a/src/viced/afsfileprocs.c +++ b/src/viced/afsfileprocs.c @@ -6503,7 +6503,7 @@ SRXAFS_GetCapabilities(struct rx_call * acall, Capabilities * capabilities) code = CallPostamble(tcon, code, thost); - return 0; + return code; } afs_int32 -- 2.39.5