From f77bf62c4b315d73176bd61fbb9248e613881c7e Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Fri, 9 May 2014 11:43:35 -0400 Subject: [PATCH] aklog: double get_credv5 in retry logic Fix a bug where get_credv5() is called twice, even if the first one succeeded, in the aklog retry logic. (This bug uncovers another bug where get_credv5_akimpersonate crashes in the krb5 libs when get_credv5 is called back to back.) Reviewed-on: http://gerrit.openafs.org/11133 Reviewed-by: Benjamin Kaduk Tested-by: BuildBot Reviewed-by: Jeffrey Altman (cherry picked from commit b9979e1a23ce28b20fe95d5e6042b9b15506c993) Change-Id: I53b274f5e417ebd2a88b18df15ceb0e1ea39624d Reviewed-on: http://gerrit.openafs.org/11218 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: Benjamin Kaduk Reviewed-by: Perry Ruiter Reviewed-by: Stephan Wiesand --- src/aklog/aklog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/aklog/aklog.c b/src/aklog/aklog.c index deb2a42e5..7782b0c9c 100644 --- a/src/aklog/aklog.c +++ b/src/aklog/aklog.c @@ -538,9 +538,9 @@ rxkad_get_ticket(krb5_context context, char *realm, } afs_dprintf("We've deduced that we need to authenticate" " to realm %s.\n", realm_of_cell); + status = get_credv5(context, AFSKEY, cell->name, + realm_of_cell, v5cred); } - status = get_credv5(context, AFSKEY, cell->name, - realm_of_cell, v5cred); } /* If the realm and cell name match, then try without an -- 2.39.5